Skip test dependent on Scrivito from forked repo PR #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `scriviton_path(Obj.root)` means `/`, we can replace to `root_url`.
Closed
|
同じコミットハッシュだと違うPRでもテスト結果が同じになってしまうのかな？🤔 |
nalabjp
changed the title
|
#210 のCIが通るまでマージしてはいけないのでWIPにしました |
|
ひとまず 55e1208 で 💚 55e1208 のコミットでCmsControllerがロードされても b882f0d のテストのようなことが無くなりそうに思えるので、 |
nalabjp
changed the title
|
#210 もCI 👌 なのでWIP外しました。 |
|
@nalabjp PRありがとうございます! 😆 ✨ 確認しました! ✅ 👀 コミットだけsquashなどしてまとめてもらえると嬉しいです ;) 他は特に気になる点はなかったので、コミットがまとまったらマージしちゃいますね 🔧 💨 |
|
レビューありがとうございます😁 |
|
🎉 ✨ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #160
ref #203 (comment)
Changes
scrivito: trueというRSpecのタグを付与したscrivito_path(Obj.root)は/を意味しているのでroot_urlに置き換え可能なためscrivito: trueなタグが付与されているテストを除外して実行するようにしたSCRIVITO_TENANTとSCRIVITO_API_KEYの環境変数が必要なため